test(rules): add final QA evidence and mark review complete

Final Review Results:
- F1 (Plan Compliance): OKAY - Must Have [12/12], Must NOT Have [8/8]
- F2 (Code Quality): OKAY - All files pass quality criteria
- F3 (Manual QA): OKAY - Scenarios [5/5 pass]
- F4 (Scope Fidelity): OKAY - No unaccounted changes

All 21 tasks complete (T1-T17 + F1-F4)

.sisyphus/evidence/final-qa/scenario1-empty-config.json

@@ -0,0 +1 @@
+{"instructions":[".opencode-rules/concerns/coding-style.md",".opencode-rules/concerns/naming.md",".opencode-rules/concerns/documentation.md",".opencode-rules/concerns/testing.md",".opencode-rules/concerns/git-workflow.md",".opencode-rules/concerns/project-structure.md"],"shellHook":"# Create/update symlink to AGENTS rules directory\nln -sfn /nix/store/wsqzf0z3hg8mhpq484f24fm72qp4k6sg-AGENTS/rules .opencode-rules\n\n# Generate opencode.json configuration file\ncat > opencode.json <<'OPENCODE_EOF'\n{\"$schema\":\"https://opencode.ai/config.json\",\"instructions\":[\".opencode-rules/concerns/coding-style.md\",\".opencode-rules/concerns/naming.md\",\".opencode-rules/concerns/documentation.md\",\".opencode-rules/concerns/testing.md\",\".opencode-rules/concerns/git-workflow.md\",\".opencode-rules/concerns/project-structure.md\"]}\nOPENCODE_EOF\n"}

.sisyphus/evidence/final-qa/scenario2-single-language.json

@@ -0,0 +1 @@
+{"instructions":[".opencode-rules/concerns/coding-style.md",".opencode-rules/concerns/naming.md",".opencode-rules/concerns/documentation.md",".opencode-rules/concerns/testing.md",".opencode-rules/concerns/git-workflow.md",".opencode-rules/concerns/project-structure.md",".opencode-rules/languages/python.md"],"shellHook":"# Create/update symlink to AGENTS rules directory\nln -sfn /nix/store/4li05383sgf4z0l6bxv8hmvgs600y56x-AGENTS/rules .opencode-rules\n\n# Generate opencode.json configuration file\ncat > opencode.json <<'OPENCODE_EOF'\n{\"$schema\":\"https://opencode.ai/config.json\",\"instructions\":[\".opencode-rules/concerns/coding-style.md\",\".opencode-rules/concerns/naming.md\",\".opencode-rules/concerns/documentation.md\",\".opencode-rules/concerns/testing.md\",\".opencode-rules/concerns/git-workflow.md\",\".opencode-rules/concerns/project-structure.md\",\".opencode-rules/languages/python.md\"]}\nOPENCODE_EOF\n"}

.sisyphus/evidence/final-qa/scenario3-multi-language.json

@@ -0,0 +1 @@
+{"instructions":[".opencode-rules/concerns/coding-style.md",".opencode-rules/concerns/naming.md",".opencode-rules/concerns/documentation.md",".opencode-rules/concerns/testing.md",".opencode-rules/concerns/git-workflow.md",".opencode-rules/concerns/project-structure.md",".opencode-rules/languages/python.md",".opencode-rules/languages/typescript.md",".opencode-rules/languages/nix.md",".opencode-rules/languages/shell.md"],"shellHook":"# Create/update symlink to AGENTS rules directory\nln -sfn /nix/store/qzsdn3m85qwarpd43x8k28sja40r21p7-AGENTS/rules .opencode-rules\n\n# Generate opencode.json configuration file\ncat > opencode.json <<'OPENCODE_EOF'\n{\"$schema\":\"https://opencode.ai/config.json\",\"instructions\":[\".opencode-rules/concerns/coding-style.md\",\".opencode-rules/concerns/naming.md\",\".opencode-rules/concerns/documentation.md\",\".opencode-rules/concerns/testing.md\",\".opencode-rules/concerns/git-workflow.md\",\".opencode-rules/concerns/project-structure.md\",\".opencode-rules/languages/python.md\",\".opencode-rules/languages/typescript.md\",\".opencode-rules/languages/nix.md\",\".opencode-rules/languages/shell.md\"]}\nOPENCODE_EOF\n"}

.sisyphus/evidence/final-qa/scenario4-with-frameworks.json

@@ -0,0 +1 @@
+{"instructions":[".opencode-rules/concerns/coding-style.md",".opencode-rules/concerns/naming.md",".opencode-rules/concerns/documentation.md",".opencode-rules/concerns/testing.md",".opencode-rules/concerns/git-workflow.md",".opencode-rules/concerns/project-structure.md",".opencode-rules/languages/python.md",".opencode-rules/frameworks/n8n.md"],"shellHook":"# Create/update symlink to AGENTS rules directory\nln -sfn /nix/store/55brjhy9m1vcgrnd100vmwf9bycjpzpi-AGENTS/rules .opencode-rules\n\n# Generate opencode.json configuration file\ncat > opencode.json <<'OPENCODE_EOF'\n{\"$schema\":\"https://opencode.ai/config.json\",\"instructions\":[\".opencode-rules/concerns/coding-style.md\",\".opencode-rules/concerns/naming.md\",\".opencode-rules/concerns/documentation.md\",\".opencode-rules/concerns/testing.md\",\".opencode-rules/concerns/git-workflow.md\",\".opencode-rules/concerns/project-structure.md\",\".opencode-rules/languages/python.md\",\".opencode-rules/frameworks/n8n.md\"]}\nOPENCODE_EOF\n"}

.sisyphus/evidence/final-qa/scenario5-extra-instructions.json

@@ -0,0 +1 @@
+{"instructions":[".opencode-rules/concerns/coding-style.md",".opencode-rules/concerns/naming.md",".opencode-rules/concerns/documentation.md",".opencode-rules/concerns/testing.md",".opencode-rules/concerns/git-workflow.md",".opencode-rules/concerns/project-structure.md",".opencode-rules/languages/python.md",".opencode-rules/custom.md"],"shellHook":"# Create/update symlink to AGENTS rules directory\nln -sfn /nix/store/r8yfirsyyii9x05qd5kfdvzcqv7sx6az-AGENTS/rules .opencode-rules\n\n# Generate opencode.json configuration file\ncat > opencode.json <<'OPENCODE_EOF'\n{\"$schema\":\"https://opencode.ai/config.json\",\"instructions\":[\".opencode-rules/concerns/coding-style.md\",\".opencode-rules/concerns/naming.md\",\".opencode-rules/concerns/documentation.md\",\".opencode-rules/concerns/testing.md\",\".opencode-rules/concerns/git-workflow.md\",\".opencode-rules/concerns/project-structure.md\",\".opencode-rules/languages/python.md\",\".opencode-rules/custom.md\"]}\nOPENCODE_EOF\n"}

.sisyphus/evidence/final-qa/summary.md

@@ -0,0 +1,153 @@
+# Opencode Rules Nix Module - Manual QA Results
+
+## Test Summary
+Date: 2025-02-17
+Module: `/home/m3tam3re/p/NIX/nixpkgs/lib/opencode-rules.nix`
+Test Type: Manual QA (nix eval)
+
+---
+
+## Scenario Results
+
+### Scenario 1: Empty Config (Defaults Only)
+**Command**: `nix eval --impure --json --expr 'let pkgs = import <nixpkgs> {}; m3taLib = import /home/m3tam3re/p/NIX/nixpkgs/lib {lib = pkgs.lib;}; in m3taLib.opencode-rules.mkOpencodeRules { agents = /home/m3tam3re/p/AI/AGENTS; }'`
+
+**Results**:
+- ✅ Valid JSON output
+- ✅ Has `$schema` field in embedded opencode.json
+- ✅ Has `instructions` field
+- ✅ Correct instruction count: 6 (default concerns only)
+
+**Expected Instructions**:
+1. `.opencode-rules/concerns/coding-style.md`
+2. `.opencode-rules/concerns/naming.md`
+3. `.opencode-rules/concerns/documentation.md`
+4. `.opencode-rules/concerns/testing.md`
+5. `.opencode-rules/concerns/git-workflow.md`
+6. `.opencode-rules/concerns/project-structure.md`
+
+---
+
+### Scenario 2: Single Language (Python)
+**Command**: `nix eval --impure --json --expr 'let pkgs = import <nixpkgs> {}; m3taLib = import /home/m3tam3re/p/NIX/nixpkgs/lib {lib = pkgs.lib;}; in m3taLib.opencode-rules.mkOpencodeRules { agents = /home/m3tam3re/p/AI/AGENTS; languages = ["python"]; }'`
+
+**Results**:
+- ✅ Valid JSON output
+- ✅ Has `$schema` field in embedded opencode.json
+- ✅ Has `instructions` field
+- ✅ Correct instruction count: 7 (6 concerns + 1 language)
+
+**Expected Instructions**:
+- All 6 default concerns
+- `.opencode-rules/languages/python.md`
+
+---
+
+### Scenario 3: Multi-Language
+**Command**: `nix eval --impure --json --expr 'let pkgs = import <nixpkgs> {}; m3taLib = import /home/m3tam3re/p/NIX/nixpkgs/lib {lib = pkgs.lib;}; in m3taLib.opencode-rules.mkOpencodeRules { agents = /home/m3tam3re/p/AI/AGENTS; languages = ["python" "typescript" "nix" "shell"]; }'`
+
+**Results**:
+- ✅ Valid JSON output
+- ✅ Has `$schema` field in embedded opencode.json
+- ✅ Has `instructions` field
+- ✅ Correct instruction count: 10 (6 concerns + 4 languages)
+
+**Expected Instructions**:
+- All 6 default concerns
+- `.opencode-rules/languages/python.md`
+- `.opencode-rules/languages/typescript.md`
+- `.opencode-rules/languages/nix.md`
+- `.opencode-rules/languages/shell.md`
+
+---
+
+### Scenario 4: With Frameworks
+**Command**: `nix eval --impure --json --expr 'let pkgs = import <nixpkgs> {}; m3taLib = import /home/m3tam3re/p/NIX/nixpkgs/lib {lib = pkgs.lib;}; in m3taLib.opencode-rules.mkOpencodeRules { agents = /home/m3tam3re/p/AI/AGENTS; languages = ["python"]; frameworks = ["n8n"]; }'`
+
+**Results**:
+- ✅ Valid JSON output
+- ✅ Has `$schema` field in embedded opencode.json
+- ✅ Has `instructions` field
+- ✅ Correct instruction count: 8 (6 concerns + 1 language + 1 framework)
+
+**Expected Instructions**:
+- All 6 default concerns
+- `.opencode-rules/languages/python.md`
+- `.opencode-rules/frameworks/n8n.md`
+
+---
+
+### Scenario 5: Extra Instructions
+**Command**: `nix eval --impure --json --expr 'let pkgs = import <nixpkgs> {}; m3taLib = import /home/m3tam3re/p/NIX/nixpkgs/lib {lib = pkgs.lib;}; in m3taLib.opencode-rules.mkOpencodeRules { agents = /home/m3tam3re/p/AI/AGENTS; languages = ["python"]; extraInstructions = [".opencode-rules/custom.md"]; }'`
+
+**Results**:
+- ✅ Valid JSON output
+- ✅ Has `$schema` field in embedded opencode.json
+- ✅ Has `instructions` field
+- ✅ Correct instruction count: 8 (6 concerns + 1 language + 1 custom)
+
+**Expected Instructions**:
+- All 6 default concerns
+- `.opencode-rules/languages/python.md`
+- `.opencode-rules/custom.md`
+
+---
+
+## Content Quality Spot Checks
+
+### 1. coding-style.md (Concern Rule)
+**Assessment**: ✅ High Quality
+- Clear critical rules with "Always/Never" directives
+- Good vs. bad code examples
+- Comprehensive coverage: formatting, patterns, error handling, type safety, function design, SOLID
+- Well-structured sections
+
+### 2. python.md (Language Rule)
+**Assessment**: ✅ High Quality
+- Modern toolchain recommendations (uv, ruff, pyright, pytest, hypothesis)
+- Common idioms with practical examples
+- Anti-patterns with explanations
+- Project setup structure
+- Clear, actionable code snippets
+
+### 3. n8n.md (Framework Rule)
+**Assessment**: ✅ High Quality
+- Concise workflow design principles
+- Clear naming conventions
+- Error handling patterns
+- Security best practices
+- Actionable testing guidelines
+
+---
+
+## Issues Encountered
+
+### Socket File Issue
+**Issue**: `nix eval` failed with `error: file '/home/m3tam3re/p/AI/AGENTS/.beads/bd.sock' has an unsupported type`
+
+**Workaround**: Temporarily moved `.beads` directory outside the AGENTS tree during testing
+
+**Root Cause**: Nix attempts to evaluate/store the `agents` path recursively and encounters unsupported socket files (Unix domain sockets)
+
+**Recommendation**: Consider adding `.beads` to `.gitignore` and excluding it from path evaluation if possible, or document this limitation for users
+
+---
+
+## Final Verdict
+
+```
+Scenarios [5/5 pass] | VERDICT: OKAY
+```
+
+### Summary
+- All 5 test scenarios executed successfully
+- All JSON outputs are valid and properly structured
+- All embedded `opencode.json` configurations have required `$schema` and `instructions` fields
+- Instruction counts match expected values for each scenario
+- Rule content quality is high across concern, language, and framework rules
+- Shell hook properly generates symlink and configuration file
+
+### Notes
+- Socket file issue requires workaround (documented)
+- Module correctly handles default concerns, multiple languages, frameworks, and custom instructions
+- Code examples in rules are clear and actionable

.sisyphus/plans/rules-system.md

@@ -746,19 +746,19 @@ Max Concurrent: 11 (Wave 2)
 
 > 4 review agents run in PARALLEL. ALL must APPROVE. Rejection → fix → re-run.
 
-- [ ] F1. **Plan Compliance Audit** — `oracle`
+- [x] F1. **Plan Compliance Audit** — `oracle`
   For each "Must Have": verify implementation exists. For each "Must NOT Have": search for violations. Check evidence files. Compare deliverables across all 3 repos.
   Output: `Must Have [N/N] | Must NOT Have [N/N] | Tasks [N/N] | VERDICT`
 
-- [ ] F2. **Code Quality Review** — `unspecified-high`
+- [x] F2. **Code Quality Review** — `unspecified-high`
   Rule files: no generic advice, has examples, consistent tone, under limits. Nix: valid syntax, correct paths, edge cases. USAGE.md: accurate.
   Output: `Files [N clean/N issues] | VERDICT`
 
-- [ ] F3. **Real Manual QA** — `unspecified-high`
+- [x] F3. **Real Manual QA** — `unspecified-high`
   Run `nix eval` on opencode-rules.nix via full lib import with various configs. Verify JSON. Check rule content quality. Save to `.sisyphus/evidence/final-qa/`.
   Output: `Scenarios [N/N pass] | VERDICT`
 
-- [ ] F4. **Scope Fidelity Check** — `deep`
+- [x] F4. **Scope Fidelity Check** — `deep`
   For each task: "What to do" vs actual file. 1:1 match. No creep. Check "Must NOT do". Flag unaccounted changes across all 3 repos.
   Output: `Tasks [N/N compliant] | Unaccounted [CLEAN/N files] | VERDICT`