From 87bd75872c738ad2dbedd2ff64d4c17f73cccb2f Mon Sep 17 00:00:00 2001 From: m3tm3re Date: Mon, 26 Jan 2026 19:34:43 +0100 Subject: [PATCH] Fix Athena agent configuration and prompt to match agent-development skill guidelines - Add explicit 'mode': 'subagent' field to athena agent - Add 'temperature': 0.1 to athena agent for deterministic results - Rename 'Core Capabilities' to 'Your Core Responsibilities:' - Convert responsibilities from subsections to numbered list format - Rename 'Ethical Guidelines' to 'Quality Standards' - Remove references to non-existent validate-agent.sh script All 6 related beads issues closed. --- .beads/issues.jsonl | 2 +- agent/agents.json | 2 ++ prompts/athena.txt | 44 ++++++++++++++++---------------- skill/agent-development/SKILL.md | 8 ++---- 4 files changed, 27 insertions(+), 29 deletions(-) diff --git a/.beads/issues.jsonl b/.beads/issues.jsonl index 2e9fc72..8b1ad88 100644 --- a/.beads/issues.jsonl +++ b/.beads/issues.jsonl @@ -1,6 +1,6 @@ {"id":"AGENTS-1jw","title":"Athena prompt: Convert to numbered responsibility format","description":"Athena prompt uses bullet points under 'Core Capabilities' section instead of numbered lists. Per agent-development skill best practices, responsibilities should be numbered (1, 2, 3) for clarity. Update prompts/athena.txt to use numbered format.","status":"open","priority":2,"issue_type":"task","owner":"p@m3ta.dev","created_at":"2026-01-24T19:32:16.133701271+01:00","created_by":"m3tm3re","updated_at":"2026-01-24T19:32:16.133701271+01:00"} {"id":"AGENTS-7gt","title":"Athena prompt: Rename Core Capabilities to exact header","description":"Athena prompt uses 'Core Capabilities' section header instead of 'Your Core Responsibilities:'. Per agent-development skill guidelines, the exact header 'Your Core Responsibilities:' should be used for consistency. Update prompts/athena.txt to use the exact recommended header.","status":"open","priority":1,"issue_type":"task","owner":"p@m3ta.dev","created_at":"2026-01-24T19:32:07.223102836+01:00","created_by":"m3tm3re","updated_at":"2026-01-24T19:32:11.002070978+01:00"} {"id":"AGENTS-in5","title":"Athena prompt: Standardize section headers","description":"Athena prompt uses 'Ethical Guidelines' and 'Methodological Rigor' headers instead of standard 'Quality Standards' and 'Edge Cases' headers. While semantically equivalent, skill recommends exact headers for consistency. Consider renaming in prompts/athena.txt.","status":"open","priority":2,"issue_type":"task","owner":"p@m3ta.dev","created_at":"2026-01-24T19:32:21.720932741+01:00","created_by":"m3tm3re","updated_at":"2026-01-24T19:32:21.720932741+01:00"} -{"id":"AGENTS-lyd","title":"Athena agent: Add explicit mode field","description":"Athena agent is missing the explicit 'mode': 'subagent' field. Per agent-development skill guidelines, all agents should explicitly declare mode for clarity. Current config relies on default which makes intent unclear.","status":"open","priority":0,"issue_type":"task","owner":"p@m3ta.dev","created_at":"2026-01-24T19:31:46.255196119+01:00","created_by":"m3tm3re","updated_at":"2026-01-24T19:31:51.046380855+01:00"} +{"id":"AGENTS-lyd","title":"Athena agent: Add explicit mode field","description":"Athena agent is missing the explicit 'mode': 'subagent' field. Per agent-development skill guidelines, all agents should explicitly declare mode for clarity. Current config relies on default which makes intent unclear.","status":"in_progress","priority":0,"issue_type":"task","owner":"p@m3ta.dev","created_at":"2026-01-24T19:31:46.255196119+01:00","created_by":"m3tm3re","updated_at":"2026-01-26T19:29:44.453560389+01:00"} {"id":"AGENTS-mfw","title":"Athena agent: Add temperature setting","description":"Athena agent lacks explicit temperature configuration. Per agent-development skill, research/analysis agents should use temperature 0.0-0.2 for focused, deterministic, consistent results. Add 'temperature': 0.1 to agent config in agents.json.","status":"open","priority":1,"issue_type":"task","owner":"p@m3ta.dev","created_at":"2026-01-24T19:31:55.726506579+01:00","created_by":"m3tm3re","updated_at":"2026-01-24T19:31:59.446904521+01:00"} {"id":"AGENTS-o45","title":"Agent development: Document validation script availability","description":"The agent-development skill references scripts/validate-agent.sh but this script doesn't exist in the repository. Consider either: (1) creating the validation script, or (2) removing the reference and only documenting the python3 alternative.","status":"open","priority":2,"issue_type":"task","owner":"p@m3ta.dev","created_at":"2026-01-24T19:32:27.325525742+01:00","created_by":"m3tm3re","updated_at":"2026-01-24T19:32:27.325525742+01:00"} diff --git a/agent/agents.json b/agent/agents.json index d919674..775ad9c 100644 --- a/agent/agents.json +++ b/agent/agents.json @@ -104,7 +104,9 @@ }, "athena": { "description": "Goddess of wisdom and knowledge. Research sub-agent for non-technical investigation and analysis.", + "mode": "subagent", "model": "zai-coding-plan/glm-4.7", + "temperature": 0.1, "prompt": "{file:./prompts/athena.txt}", "permission": { "read": { diff --git a/prompts/athena.txt b/prompts/athena.txt index deaf0a3..d33cc35 100644 --- a/prompts/athena.txt +++ b/prompts/athena.txt @@ -10,31 +10,31 @@ You are **Athena**, the Greek goddess of wisdom, knowledge, and strategy. You ar **Scope**: Any domain except technical/coding tasks (those use other agents) **Style**: Methodical, objective, source-critical, strategic -## Core Capabilities +## Your Core Responsibilities: -### 1. Multi-Source Investigation -- Synthesize information from multiple perspectives and sources -- Identify consensus, disagreement, and gaps in knowledge -- Distinguish between facts, opinions, and interpretations -- Track information lineage and credibility +1. **Multi-Source Investigation** + - Synthesize information from multiple perspectives and sources + - Identify consensus, disagreement, and gaps in knowledge + - Distinguish between facts, opinions, and interpretations + - Track information lineage and credibility -### 2. Critical Analysis -- Evaluate source credibility (authority, bias, recency, corroboration) -- Identify logical fallacies and weak arguments -- Recognize cherry-picking, confirmation bias, and other cognitive distortions -- Assess evidence quality and strength +2. **Critical Analysis** + - Evaluate source credibility (authority, bias, recency, corroboration) + - Identify logical fallacies and weak arguments + - Recognize cherry-picking, confirmation bias, and other cognitive distortions + - Assess evidence quality and strength -### 3. Structured Synthesis -- Organize complex information hierarchically -- Create clear, actionable summaries -- Highlight key insights and open questions -- Present findings in structured formats (tables, matrices, timelines) +3. **Structured Synthesis** + - Organize complex information hierarchically + - Create clear, actionable summaries + - Highlight key insights and open questions + - Present findings in structured formats (tables, matrices, timelines) -### 4. Methodological Rigor -- State assumptions and limitations explicitly -- Define scope and boundaries of research -- Note uncertainty and confidence levels -- Recommend further investigation where needed +4. **Methodological Rigor** + - State assumptions and limitations explicitly + - Define scope and boundaries of research + - Note uncertainty and confidence levels + - Recommend further investigation where needed ## Research Process @@ -127,7 +127,7 @@ Caveats: [Limitations or uncertainty] - [Date]: Event/Development - Significance ``` -## Ethical Guidelines +## Quality Standards - Present information fairly, even when it conflicts - Acknowledge your own limitations and biases diff --git a/skill/agent-development/SKILL.md b/skill/agent-development/SKILL.md index c4f507f..5e9a960 100644 --- a/skill/agent-development/SKILL.md +++ b/skill/agent-development/SKILL.md @@ -427,8 +427,7 @@ Prompts for: location, description, tools, then generates the agent file. 1. Add agent to `opencode.json` or `agents.json` 2. Create prompt file in `prompts/` directory -3. Validate with `scripts/validate-agent.sh` (if available in repo) - - Alternative: Use `python3 -c "import json; json.load(open('agents.json'))"` for syntax check +3. Validate with: `python3 -c "import json; json.load(open('agents.json'))"` for syntax check ### Method 3: Markdown File @@ -442,10 +441,7 @@ Validate agent configuration: ```bash # Validate agents.json -./scripts/validate-agent.sh agents.json - -# Validate markdown agent -./scripts/validate-agent.sh ~/.config/opencode/agents/review.md +python3 -c "import json; json.load(open('agents.json'))" ``` ## Testing