fix(client): harden label pinning and close review findings
- Resolve the Windows admin config via the ProgramData known folder instead of the user-controlled ProgramData variable, so a user cannot redirect the admin lookup and drop pinned labels - vendor rename rewrites matching agent-lib.labels.json entries, so a renamed item keeps its labels instead of going to every client - validate checks the labels file in repositories without a lockfile - A kept modified copy of a deselected item is no longer drift in status, and the toast explains it as "no longer assigned to you" - Labels parser rejects trailing data such as an extra closing brace - Tests: admin pin wiring (config chain, --repo, admin as chosen config), reselect redeploy with byte-level no-op, status labels JSON, validate without lockfile, rename keeps labels - README: document unreadable admin config, drift semantics, rename Refs: agent_lib-fh4 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
59735c3b24
commit
ae316860e5
17 files changed
+296
-17
No files matched your search
+25
@@ -0,0 +1,25 @@
|
||||
package vendor
|
||||
|
||||
import (
|
||||
"os"
|
||||
"path/filepath"
|
||||
"strings"
|
||||
"testing"
|
||||
)
|
||||
|
||||
func TestRenameLabelEntriesKeepsLabels(t *testing.T) {
|
||||
dir := t.TempDir()
|
||||
p := filepath.Join(dir, "agent-lib.labels.json")
|
||||
os.WriteFile(p, []byte(`{"version":1,"labels":{"sales":["old-name","other"],"dev":["old-name"]}}`), 0o644)
|
||||
n, err := renameLabelEntries(dir, map[string]string{"old-name": "new-name"})
|
||||
if err != nil || n != 2 {
|
||||
t.Fatalf("want 2 entries renamed, got %d, %v", n, err)
|
||||
}
|
||||
data, _ := os.ReadFile(p)
|
||||
if strings.Contains(string(data), "old-name") || strings.Count(string(data), "new-name") != 2 {
|
||||
t.Errorf("entries not rewritten:\n%s", data)
|
||||
}
|
||||
if n, err := renameLabelEntries(t.TempDir(), map[string]string{"a": "b"}); err != nil || n != 0 {
|
||||
t.Errorf("missing labels file must be a no-op, got %d, %v", n, err)
|
||||
}
|
||||
}
|
||||
Reference in new issue
Block a user