m3tam3re/basecamp-mcp-server
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 1 Wiki Activity

Fix review issues in pagination implementation

Browse Source 
- Move `import re` to top of file (was inline in function)
- Add page parameter validation (page >= 1)
- Fix parameter order bug in search_utils.py (was swapped)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
George Antonopoulos
2026-01-14 19:34:51 +00:00
parent 67d68af1da
commit 43aa595433
2 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
search_utils.py
View File

@@ -467,7 +467,7 @@ class BasecampSearch:
try:
# If both recording_id and bucket_id are provided, get comments for that specific recording
if recording_id and bucket_id:
result = self.client.get_comments(recording_id, bucket_id)
result = self.client.get_comments(bucket_id, recording_id)
comments = result["comments"]
# Otherwise we can't search across all comments as there's no endpoint for that
else: