302 lines
12 KiB
JavaScript
302 lines
12 KiB
JavaScript
|
/**
|
||
|
|
* @process local/fix-nix-eval-warnings
|
||
|
|
* @description Fix Nix/Home Manager evaluation warnings except the nh/gc conflict warning.
|
||
|
|
* @skill systematic-debugging methodologies/superpowers/systematic-debugging.js
|
||
|
|
* @skill verification-before-completion methodologies/superpowers/verification-before-completion.js
|
||
|
|
* @skill root-cause-diagnosis methodologies/shared/root-cause-diagnosis.js
|
||
|
|
*/
|
||
|
|
|
||
|
|
import { defineTask } from '@a5c-ai/babysitter-sdk';
|
||
|
|
|
||
|
|
const q = (value) => `'${String(value).replace(/'/g, `'\\''`)}'`;
|
||
|
|
|
||
|
|
export async function process(inputs, ctx) {
|
||
|
|
const nixosConfigDir = inputs.nixosConfigDir || '/home/m3tam3re/p/NIX/nixos-config';
|
||
|
|
const m3taHomeDir = inputs.m3taHomeDir || '/home/m3tam3re/p/NIX/m3ta-home';
|
||
|
|
const specPath = inputs.specPath || `${nixosConfigDir}/.a5c/inputs/fix-eval-warnings-spec.md`;
|
||
|
|
|
||
|
|
const spec = await ctx.task(readSpecTask, { specPath });
|
||
|
|
|
||
|
|
const inspection = await ctx.task(inspectWarningSourcesTask, {
|
||
|
|
nixosConfigDir,
|
||
|
|
m3taHomeDir,
|
||
|
|
});
|
||
|
|
|
||
|
|
const implementation = await ctx.task(implementFixesTask, {
|
||
|
|
nixosConfigDir,
|
||
|
|
m3taHomeDir,
|
||
|
|
spec: spec.stdout,
|
||
|
|
inspection: inspection.stdout,
|
||
|
|
});
|
||
|
|
|
||
|
|
const formatting = await ctx.task(formatChangedNixTask, {
|
||
|
|
m3taHomeDir,
|
||
|
|
});
|
||
|
|
|
||
|
|
const verification = await ctx.task(verifyWarningsTask, {
|
||
|
|
nixosConfigDir,
|
||
|
|
m3taHomeDir,
|
||
|
|
});
|
||
|
|
|
||
|
|
const artifacts = await ctx.task(collectArtifactsTask, {
|
||
|
|
nixosConfigDir,
|
||
|
|
m3taHomeDir,
|
||
|
|
verifyStdout: verification.stdout || '',
|
||
|
|
verifyStderr: verification.stderr || '',
|
||
|
|
});
|
||
|
|
|
||
|
|
const acceptance = await ctx.task(acceptanceReviewTask, {
|
||
|
|
spec: spec.stdout,
|
||
|
|
artifacts: artifacts.stdout,
|
||
|
|
});
|
||
|
|
|
||
|
|
if (!acceptance.accepted) {
|
||
|
|
await ctx.breakpoint({
|
||
|
|
title: 'Warning fix acceptance review failed',
|
||
|
|
question: `Acceptance review did not approve the changes: ${acceptance.reason}`,
|
||
|
|
context: {
|
||
|
|
runId: ctx.runId,
|
||
|
|
files: [
|
||
|
|
{ path: `${m3taHomeDir}/users/m3tam3re/identities/private.nix`, format: 'nix', label: 'Private SSH identity' },
|
||
|
|
{ path: `${m3taHomeDir}/profiles/sets/coding/agents/agents.nix`, format: 'nix', label: 'Agent packages' },
|
||
|
|
{ path: `${m3taHomeDir}/profiles/contexts/desktop/default.nix`, format: 'nix', label: 'Desktop packages' },
|
||
|
|
],
|
||
|
|
},
|
||
|
|
});
|
||
|
|
}
|
||
|
|
|
||
|
|
return {
|
||
|
|
success: acceptance.accepted,
|
||
|
|
summary: implementation.summary,
|
||
|
|
changedFiles: implementation.changedFiles,
|
||
|
|
verification: {
|
||
|
|
formatting: formatting.stdout,
|
||
|
|
warnings: verification.stdout,
|
||
|
|
review: acceptance,
|
||
|
|
},
|
||
|
|
};
|
||
|
|
}
|
||
|
|
|
||
|
|
export const readSpecTask = defineTask('read-spec', (args, taskCtx) => ({
|
||
|
|
kind: 'shell',
|
||
|
|
title: 'Read warning-fix spec',
|
||
|
|
shell: {
|
||
|
|
command: `cat ${q(args.specPath)}`,
|
||
|
|
expectedExitCode: 0,
|
||
|
|
timeout: 10000,
|
||
|
|
},
|
||
|
|
io: {
|
||
|
|
inputJsonPath: `tasks/${taskCtx.effectId}/input.json`,
|
||
|
|
outputJsonPath: `tasks/${taskCtx.effectId}/output.json`,
|
||
|
|
},
|
||
|
|
labels: ['spec', 'shell'],
|
||
|
|
}));
|
||
|
|
|
||
|
|
export const inspectWarningSourcesTask = defineTask('inspect-warning-sources', (args, taskCtx) => ({
|
||
|
|
kind: 'shell',
|
||
|
|
title: 'Inspect current warning sources',
|
||
|
|
shell: {
|
||
|
|
command: [
|
||
|
|
'set -euo pipefail',
|
||
|
|
`echo '== nixos-config status =='`,
|
||
|
|
`cd ${q(args.nixosConfigDir)} && git status --short`,
|
||
|
|
`echo`,
|
||
|
|
`echo '== m3ta-home status =='`,
|
||
|
|
`cd ${q(args.m3taHomeDir)} && git status --short`,
|
||
|
|
`echo`,
|
||
|
|
`echo '== active pkgs.system-style package selectors =='`,
|
||
|
|
`grep -RIn --include='*.nix' -E 'packages[.]\\$\\{pkgs[.]system\\}|packages[.]\\$\\{prev[.]system\\}|packages[.]\\$\\{final[.]system\\}' ${q(args.nixosConfigDir)} ${q(args.m3taHomeDir)} || true`,
|
||
|
|
`echo`,
|
||
|
|
`echo '== SSH matchBlocks in m3ta-home identities =='`,
|
||
|
|
`grep -RIn --include='*.nix' 'matchBlocks' ${q(`${args.m3taHomeDir}/users/m3tam3re/identities`)} || true`,
|
||
|
|
].join('\n'),
|
||
|
|
expectedExitCode: 0,
|
||
|
|
timeout: 30000,
|
||
|
|
},
|
||
|
|
io: {
|
||
|
|
inputJsonPath: `tasks/${taskCtx.effectId}/input.json`,
|
||
|
|
outputJsonPath: `tasks/${taskCtx.effectId}/output.json`,
|
||
|
|
},
|
||
|
|
labels: ['diagnosis', 'shell'],
|
||
|
|
}));
|
||
|
|
|
||
|
|
export const implementFixesTask = defineTask('implement-warning-fixes', (args, taskCtx) => ({
|
||
|
|
kind: 'agent',
|
||
|
|
title: 'Implement requested warning fixes',
|
||
|
|
agent: {
|
||
|
|
name: 'worker',
|
||
|
|
prompt: {
|
||
|
|
role: 'Nix/Home Manager maintenance engineer',
|
||
|
|
task: 'Edit the repositories to remove the requested evaluation warnings, excluding the nh/gc warning by request.',
|
||
|
|
context: {
|
||
|
|
nixosConfigDir: args.nixosConfigDir,
|
||
|
|
m3taHomeDir: args.m3taHomeDir,
|
||
|
|
specVerbatim: args.spec,
|
||
|
|
inspectionStdout: args.inspection,
|
||
|
|
},
|
||
|
|
instructions: [
|
||
|
|
'Execute the task fully; do not just provide a plan.',
|
||
|
|
'Do not invoke the babysit skill or create another babysitter run.',
|
||
|
|
'Read every file before editing it.',
|
||
|
|
'Preserve unrelated existing user changes, especially any dirty files in nixos-config such as flake.nix or flake.lock.',
|
||
|
|
'Fix active uses of pkgs.system/prev.system/final.system that trigger the Nixpkgs deprecation warning by using stdenv.hostPlatform.system through the appropriate package set.',
|
||
|
|
'Migrate /home/m3tam3re/p/NIX/m3ta-home/users/m3tam3re/identities/private.nix from programs.ssh.matchBlocks to programs.ssh.settings.',
|
||
|
|
'For programs.ssh.settings, use OpenSSH directive names such as HostName, User, Port, and IdentityFile; do not keep legacy camelCase option names under settings.',
|
||
|
|
'Do not change programs.nh.clean.enable or nix.gc.automatic; the user explicitly excluded that warning.',
|
||
|
|
'Keep the change minimal and focused on the warnings in the spec.',
|
||
|
|
'Run a quick static check of the edited files if practical, but leave deterministic verification to the process quality gate.',
|
||
|
|
],
|
||
|
|
outputFormat: 'JSON with summary, changedFiles, and verificationNotes.',
|
||
|
|
},
|
||
|
|
outputSchema: {
|
||
|
|
type: 'object',
|
||
|
|
required: ['summary', 'changedFiles', 'verificationNotes'],
|
||
|
|
properties: {
|
||
|
|
summary: { type: 'string' },
|
||
|
|
changedFiles: { type: 'array', items: { type: 'string' } },
|
||
|
|
verificationNotes: { type: 'array', items: { type: 'string' } },
|
||
|
|
},
|
||
|
|
},
|
||
|
|
},
|
||
|
|
io: {
|
||
|
|
inputJsonPath: `tasks/${taskCtx.effectId}/input.json`,
|
||
|
|
outputJsonPath: `tasks/${taskCtx.effectId}/output.json`,
|
||
|
|
},
|
||
|
|
labels: ['implementation', 'agent', 'nix'],
|
||
|
|
}));
|
||
|
|
|
||
|
|
export const formatChangedNixTask = defineTask('format-changed-nix', (args, taskCtx) => ({
|
||
|
|
kind: 'shell',
|
||
|
|
title: 'Format changed Nix files',
|
||
|
|
shell: {
|
||
|
|
command: [
|
||
|
|
'set -euo pipefail',
|
||
|
|
`cd ${q(args.m3taHomeDir)}`,
|
||
|
|
`if command -v alejandra >/dev/null 2>&1; then`,
|
||
|
|
` alejandra users/m3tam3re/identities/private.nix profiles/sets/coding/agents/agents.nix profiles/contexts/desktop/default.nix`,
|
||
|
|
`else`,
|
||
|
|
` nix run nixpkgs#alejandra -- users/m3tam3re/identities/private.nix profiles/sets/coding/agents/agents.nix profiles/contexts/desktop/default.nix`,
|
||
|
|
`fi`,
|
||
|
|
].join('\n'),
|
||
|
|
expectedExitCode: 0,
|
||
|
|
timeout: 120000,
|
||
|
|
},
|
||
|
|
io: {
|
||
|
|
inputJsonPath: `tasks/${taskCtx.effectId}/input.json`,
|
||
|
|
outputJsonPath: `tasks/${taskCtx.effectId}/output.json`,
|
||
|
|
},
|
||
|
|
labels: ['format', 'shell'],
|
||
|
|
}));
|
||
|
|
|
||
|
|
export const verifyWarningsTask = defineTask('verify-warning-removal', (args, taskCtx) => ({
|
||
|
|
kind: 'shell',
|
||
|
|
title: 'Verify requested warnings are gone',
|
||
|
|
shell: {
|
||
|
|
command: [
|
||
|
|
'set -euo pipefail',
|
||
|
|
`echo '== static checks =='`,
|
||
|
|
`! grep -RIn --include='*.nix' -E 'packages[.]\\$\\{pkgs[.]system\\}|packages[.]\\$\\{prev[.]system\\}|packages[.]\\$\\{final[.]system\\}' ${q(`${args.m3taHomeDir}/profiles`)} || { echo 'Found deprecated package system selector' >&2; exit 1; }`,
|
||
|
|
`! grep -n 'matchBlocks' ${q(`${args.m3taHomeDir}/users/m3tam3re/identities/private.nix`)} || { echo 'private.nix still uses matchBlocks' >&2; exit 1; }`,
|
||
|
|
`grep -n 'settings = {' ${q(`${args.m3taHomeDir}/users/m3tam3re/identities/private.nix`)}`,
|
||
|
|
`echo`,
|
||
|
|
`echo '== nix eval m3-ares =='`,
|
||
|
|
`cd ${q(args.nixosConfigDir)}`,
|
||
|
|
`eval_stdout=$(mktemp)`,
|
||
|
|
`eval_stderr=$(mktemp)`,
|
||
|
|
`set +e`,
|
||
|
|
`nix eval .#nixosConfigurations.m3-ares.config.system.build.toplevel.drvPath --show-trace >"$eval_stdout" 2>"$eval_stderr"`,
|
||
|
|
`status=$?`,
|
||
|
|
`set -e`,
|
||
|
|
`cat "$eval_stdout"`,
|
||
|
|
`cat "$eval_stderr" >&2`,
|
||
|
|
`if [ "$status" -ne 0 ]; then exit "$status"; fi`,
|
||
|
|
`if grep -F "'system' has been renamed" "$eval_stderr"; then echo 'Deprecated system warning still present' >&2; exit 1; fi`,
|
||
|
|
`if grep -F 'programs.ssh.matchBlocks' "$eval_stderr"; then echo 'Deprecated SSH matchBlocks warning still present' >&2; exit 1; fi`,
|
||
|
|
`if grep -F 'programs.nh.clean.enable and nix.gc.automatic' "$eval_stderr" >/dev/null; then echo 'Allowed nh/gc warning remains by request.'; fi`,
|
||
|
|
].join('\n'),
|
||
|
|
expectedExitCode: 0,
|
||
|
|
timeout: 300000,
|
||
|
|
},
|
||
|
|
io: {
|
||
|
|
inputJsonPath: `tasks/${taskCtx.effectId}/input.json`,
|
||
|
|
outputJsonPath: `tasks/${taskCtx.effectId}/output.json`,
|
||
|
|
},
|
||
|
|
labels: ['verification', 'shell', 'nix'],
|
||
|
|
}));
|
||
|
|
|
||
|
|
export const collectArtifactsTask = defineTask('collect-artifacts', (args, taskCtx) => ({
|
||
|
|
kind: 'shell',
|
||
|
|
title: 'Collect diffs and verification output',
|
||
|
|
shell: {
|
||
|
|
command: [
|
||
|
|
'set -euo pipefail',
|
||
|
|
`echo '== m3ta-home diff =='`,
|
||
|
|
`cd ${q(args.m3taHomeDir)} && git diff -- users/m3tam3re/identities/private.nix profiles/sets/coding/agents/agents.nix profiles/contexts/desktop/default.nix`,
|
||
|
|
`echo`,
|
||
|
|
`echo '== nixos-config diff (should not include warning fix unless needed) =='`,
|
||
|
|
`cd ${q(args.nixosConfigDir)} && git diff -- overlays/default.nix flake.nix flake.lock || true`,
|
||
|
|
`echo`,
|
||
|
|
`echo '== verification stdout =='`,
|
||
|
|
`cat <<'VERIFY_STDOUT'`,
|
||
|
|
args.verifyStdout || '',
|
||
|
|
`VERIFY_STDOUT`,
|
||
|
|
`echo`,
|
||
|
|
`echo '== verification stderr =='`,
|
||
|
|
`cat <<'VERIFY_STDERR'`,
|
||
|
|
args.verifyStderr || '',
|
||
|
|
`VERIFY_STDERR`,
|
||
|
|
].join('\n'),
|
||
|
|
expectedExitCode: 0,
|
||
|
|
timeout: 30000,
|
||
|
|
},
|
||
|
|
io: {
|
||
|
|
inputJsonPath: `tasks/${taskCtx.effectId}/input.json`,
|
||
|
|
outputJsonPath: `tasks/${taskCtx.effectId}/output.json`,
|
||
|
|
},
|
||
|
|
labels: ['artifacts', 'shell'],
|
||
|
|
}));
|
||
|
|
|
||
|
|
export const acceptanceReviewTask = defineTask('acceptance-review', (args, taskCtx) => ({
|
||
|
|
kind: 'agent',
|
||
|
|
title: 'Review changes against requested warning fixes',
|
||
|
|
agent: {
|
||
|
|
name: 'reviewer',
|
||
|
|
prompt: {
|
||
|
|
role: 'Acceptance reviewer for a Nix/Home Manager warning fix',
|
||
|
|
task: 'Compare SPEC to ARTIFACTS directly and decide whether the requested warnings were fixed without touching the excluded nh/gc warning.',
|
||
|
|
instructions: [
|
||
|
|
'Ignore any narrative in your context about how ARTIFACTS were built.',
|
||
|
|
'Do not ask for additional changes unless they are required by the SPEC.',
|
||
|
|
'Accept if the system deprecation warning and private SSH matchBlocks warning are addressed, and the nh/gc conflict remains untouched.',
|
||
|
|
'',
|
||
|
|
'SPEC (verbatim):',
|
||
|
|
'---',
|
||
|
|
args.spec,
|
||
|
|
'---',
|
||
|
|
'',
|
||
|
|
'ARTIFACTS (verbatim):',
|
||
|
|
'---',
|
||
|
|
args.artifacts,
|
||
|
|
'---',
|
||
|
|
'',
|
||
|
|
'Compare SPEC to ARTIFACTS directly. Ignore any narrative in your context about how ARTIFACTS were built.',
|
||
|
|
],
|
||
|
|
outputFormat: 'JSON with accepted boolean, reason string, and checkedCriteria array.',
|
||
|
|
},
|
||
|
|
outputSchema: {
|
||
|
|
type: 'object',
|
||
|
|
required: ['accepted', 'reason', 'checkedCriteria'],
|
||
|
|
properties: {
|
||
|
|
accepted: { type: 'boolean' },
|
||
|
|
reason: { type: 'string' },
|
||
|
|
checkedCriteria: { type: 'array', items: { type: 'string' } },
|
||
|
|
},
|
||
|
|
},
|
||
|
|
},
|
||
|
|
io: {
|
||
|
|
inputJsonPath: `tasks/${taskCtx.effectId}/input.json`,
|
||
|
|
outputJsonPath: `tasks/${taskCtx.effectId}/output.json`,
|
||
|
|
},
|
||
|
|
labels: ['acceptance', 'agent', 'review'],
|
||
|
|
}));
|