- Add `vendor rename <source> [upstream-id=name ...] [--reset ids]` to change deployed names after `vendor add`, without moving the pinned rev or selection - Persist renames in the lockfile so they survive `vendor update` and `vendor select` - Rewrite SKILL.md frontmatter `name:` to the folder name so OpenCode loads renamed skills - Validate rename targets: single path segment, no leading dot, and OpenCode skill naming rules for skills - Re-run collision checks before writing; failed renames leave lockfile and external area untouched - Add unit tests for frontmatter rewrite and name validation, plus e2e rename coverage - Document renames in README; sync beads issue export
92 lines
3.0 KiB
Go
92 lines
3.0 KiB
Go
package vendor
|
|
|
|
import (
|
|
"fmt"
|
|
"os"
|
|
"path/filepath"
|
|
"regexp"
|
|
"strings"
|
|
|
|
"github.com/m3tam3re/agent-lib/internal/lockfile"
|
|
)
|
|
|
|
// skillNameRe is the OpenCode / Agent Skills naming rule: lowercase
|
|
// alphanumerics with single hyphen separators. OpenCode additionally requires
|
|
// the SKILL.md frontmatter name to equal the folder name.
|
|
var skillNameRe = regexp.MustCompile(`^[a-z0-9]+(-[a-z0-9]+)*$`)
|
|
|
|
const maxSkillNameLen = 64
|
|
|
|
// validateRenameTarget checks a deployed-name override before it becomes a
|
|
// path segment. Every type rejects path separators and dot-names; skills must
|
|
// additionally follow the OpenCode skill naming rule so the renamed skill
|
|
// still loads.
|
|
func validateRenameTarget(typ, upstreamID, deployed string) error {
|
|
if deployed == "" {
|
|
return fmt.Errorf("rename of %q maps to an empty name", upstreamID)
|
|
}
|
|
if strings.ContainsAny(deployed, `/\`) || strings.HasPrefix(deployed, ".") || strings.TrimSpace(deployed) != deployed {
|
|
return fmt.Errorf("rename of %q to %q: name must be a single path segment without leading dot or surrounding whitespace", upstreamID, deployed)
|
|
}
|
|
if typ == lockfile.TypeSkill {
|
|
if len(deployed) > maxSkillNameLen || !skillNameRe.MatchString(deployed) {
|
|
return fmt.Errorf("rename of skill %q to %q: skill names must be 1-%d lowercase letters, digits and single hyphens (e.g. \"code-review\")", upstreamID, deployed, maxSkillNameLen)
|
|
}
|
|
}
|
|
return nil
|
|
}
|
|
|
|
// rewriteSkillName sets the frontmatter `name:` of dir/SKILL.md to name so a
|
|
// renamed skill matches its folder (OpenCode loads skills by that pairing and
|
|
// shows the frontmatter name to the user). A missing name key is inserted, a
|
|
// missing frontmatter block is created. Everything else stays byte-identical.
|
|
func rewriteSkillName(dir, name string) error {
|
|
path := filepath.Join(dir, "SKILL.md")
|
|
info, err := os.Stat(path)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
data, err := os.ReadFile(path)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
out := setFrontmatterName(string(data), name)
|
|
if out == string(data) {
|
|
return nil
|
|
}
|
|
tmp := path + ".agent-lib-tmp"
|
|
if err := os.WriteFile(tmp, []byte(out), info.Mode().Perm()); err != nil {
|
|
return err
|
|
}
|
|
return os.Rename(tmp, path)
|
|
}
|
|
|
|
func setFrontmatterName(content, name string) string {
|
|
lines := strings.SplitAfter(content, "\n")
|
|
if len(lines) == 0 || strings.TrimRight(lines[0], "\r\n") != "---" {
|
|
return "---\nname: " + name + "\n---\n" + content
|
|
}
|
|
eol := "\n"
|
|
if strings.HasSuffix(lines[0], "\r\n") {
|
|
eol = "\r\n"
|
|
}
|
|
for i := 1; i < len(lines); i++ {
|
|
bare := strings.TrimRight(lines[i], "\r\n")
|
|
if bare == "---" {
|
|
break
|
|
}
|
|
if bare == "" || bare[0] == ' ' || bare[0] == '\t' {
|
|
continue // nested/continuation lines never carry the top-level name
|
|
}
|
|
key, _, ok := strings.Cut(bare, ":")
|
|
if ok && strings.EqualFold(strings.TrimSpace(key), "name") {
|
|
lineEOL := lines[i][len(bare):]
|
|
lines[i] = "name: " + name + lineEOL
|
|
return strings.Join(lines, "")
|
|
}
|
|
}
|
|
// No name key: insert one right after the opening fence.
|
|
rest := strings.Join(lines[1:], "")
|
|
return lines[0] + "name: " + name + eol + rest
|
|
}
|